Pmm static send authorize/?client_id=some_id

Percona Monitoring and Management (PMM)
1

Description:

pmm not send value GF_AUTH_GENERIC_OAUTH_CLIENT_ID
sends a static value “some_id”

Steps to Reproduce:

add idc helm values
GF_AUTH_GENERIC_OAUTH_CLIENT_ID: ‘cG1t’
GF_AUTH_GENERIC_OAUTH_CLIENT_SECRET: ‘*’

complete authentication PMM

Version:

pmm3, chart pmm@1.4.1

Logs:

https://domain.ru/application/o/authorize/?client_id=some_id&redirect_uri=https%3A%2F%2Fpmm.ru%2Fgraph%2Flogin%2Fgeneric_oauth&response_type=code&scope=openid+profile+email+offline_access+groups&state=7LhSBgy5

Expected Result:

authorize/?client_id=pmm

Actual Result:

authorize/?client_id=some_id

2

image
image673×605 33.6 KB

these values are not passed from helm

3

Hi,
Can you check if secret.create set to true in values.yml?
Can you try to set this value in pmmEnv?

4

hi, i added secret.create: true and redeploy pod, but nothing has changed.

secret:
  create: true
  name: pmm-secret
  pmm_password: "test"

  GF_AUTH_GENERIC_OAUTH_CLIENT_ID: 'cG1t'
  GF_AUTH_GENERIC_OAUTH_CLIENT_SECRET: '*'

if look at secrets, it creates, but values no passed grafana
I can only change the value in UI grafana, then it works

image
image1576×196 6.31 KB

image
image621×524 27.4 KB

5

The logic in the helm chart seems broken (or “is more secure”, whichever ;)).

and

The secret with the client ID and Secret is only loaded into the environment if create_secret is false. If create secret is true, then only the random generated password field is loaded from the secret; the rest of the secret is ignored.

6

if secret.create is true, probably it rewrites your secret.

7

Well, it’d try to rewrite, and then k8s would say “whoa, there’s already a resource with that name” and the helm install would fail. :wink: But that’s pretty reasonable if someone says “create a secret” when they actually already have a secret.

8

if secret.create is false. Deploy not work, error: Error: secret “pmm-secret” not found

9

You should create secret with name pmm-secret first and then run helm install

10

Thanks guys, it’s working.

1 Like